From 9bb7b27b2e1803110850a3b65237f33f5a4b3854 Mon Sep 17 00:00:00 2001
From: Hendrik Rauh <114620133+HendrikRauh@users.noreply.github.com>
Date: Sat, 2 Nov 2024 23:26:03 +0100
Subject: [PATCH 1/2] fixed var name so @RaffaelW is happy

---
 src/ESPDMX.cpp | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/ESPDMX.cpp b/src/ESPDMX.cpp
index efdc7a2..bd4a44b 100644
--- a/src/ESPDMX.cpp
+++ b/src/ESPDMX.cpp
@@ -37,34 +37,34 @@ void DMXESPSerial::init()
 }
 
 // Function to read DMX data
-uint8_t DMXESPSerial::read(int Channel)
+uint8_t DMXESPSerial::read(int channel)
 {
     if (dmxStarted == false)
         init();
 
-    if (Channel < 1)
-        Channel = 1;
-    if (Channel > DMXCHANNELS)
-        Channel = DMXCHANNELS;
-    return (dmxDataStore[Channel]);
+    if (channel < 1)
+        channel = 1;
+    if (channel > DMXCHANNELS)
+        channel = DMXCHANNELS;
+    return (dmxDataStore[channel]);
 }
 
 // Function to send DMX data
-void DMXESPSerial::write(int Channel, uint8_t value)
+void DMXESPSerial::write(int channel, uint8_t value)
 {
     if (dmxStarted == false)
         init();
 
-    if (Channel < 1)
-        Channel = 1;
-    if (Channel > DMXCHANNELS)
-        Channel = DMXCHANNELS;
+    if (channel < 1)
+        channel = 1;
+    if (channel > DMXCHANNELS)
+        channel = DMXCHANNELS;
     if (value < 0)
         value = 0;
     if (value > 255)
         value = 255;
 
-    dmxDataStore[Channel] = value;
+    dmxDataStore[channel] = value;
 }
 
 void DMXESPSerial::end()

From b0521908f07300dea82775383b07ec52ba770011 Mon Sep 17 00:00:00 2001
From: Hendrik Rauh <114620133+HendrikRauh@users.noreply.github.com>
Date: Sat, 2 Nov 2024 23:57:30 +0100
Subject: [PATCH 2/2] Using more robust "Number.isNaN"

---
 data/submit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/submit.js b/data/submit.js
index 6a24318..8759386 100644
--- a/data/submit.js
+++ b/data/submit.js
@@ -13,7 +13,7 @@ function parseValue(input) {
 
     if (input.type === "number") {
         const number = Number(input.value);
-        return isNaN(number) ? null : number;
+        return Number.isNaN(number) ? null : number;
     }
 
     return input.value;