flake8 code cleanup, minor fixes

This commit is contained in:
derchris 2019-01-20 06:15:57 +01:00
parent b9eb2d234e
commit 43f08547f0
4 changed files with 606 additions and 583 deletions

View file

@ -1,4 +1,5 @@
#!/usr/bin/env python3
# vim: tabstop=4 shiftwidth=4 expandtab
import subprocess
import renderlib
@ -8,10 +9,7 @@ import shlex
import time
import sys
import os
import re
import platform
from xml.sax.saxutils import escape as xmlescape
from shutil import copyfile
# Parse arguments
@ -69,17 +67,20 @@ parser.add_argument('--bgloop', action="store_true", default=False, help='''
args = parser.parse_args()
def headline(str):
print("##################################################")
print(str)
print("##################################################")
print()
def error(str):
headline(str)
parser.print_help()
sys.exit(1)
if not args.project:
error("The Path to your project with After Effect Files is a required argument")
@ -118,14 +119,18 @@ elif args.bgloop:
else:
events = list(renderlib.events(args.schedule))
def describe_event(event):
return "#{}: {}".format(event['id'], event['title'])
def event_print(event, message):
print("{} {}".format(describe_event(event), message))
tempdir = tempfile.TemporaryDirectory()
print('working in '+tempdir.name)
print('working in ' + tempdir.name)
def fmt_command(command, **kwargs):
args = {}
@ -135,6 +140,7 @@ def fmt_command(command, **kwargs):
command = command.format(**args)
return shlex.split(command)
def run_once(command, **kwargs):
DETACHED_PROCESS = 0x00000008
return subprocess.Popen(
@ -146,89 +152,92 @@ def run_once(command, **kwargs):
close_fds=True,
creationflags=DETACHED_PROCESS)
def run(command, **kwargs):
return subprocess.check_call(
fmt_command(command, **kwargs),
stderr=subprocess.STDOUT,
stdout=subprocess.DEVNULL)
def enqueue_job(event):
event_id = str(event['id'])
if os.path.exists(os.path.join(args.project, event_id+'.ts')) or os.path.exists(os.path.join(args.project, event_id+'.mov')) and not args.force:
event_print(event, "file exist, skipping "+str(event['id']))
if os.path.exists(os.path.join(args.project, event_id + '.ts')) or os.path.exists(os.path.join(args.project, event_id + '.mov')) and not args.force:
event_print(event, "file exist, skipping " + str(event['id']))
return
work_doc = os.path.join(tempdir.name, event_id+'.aep')
script_doc = os.path.join(tempdir.name, event_id+'.jsx')
ascript_doc = os.path.join(tempdir.name, event_id+'.scpt')
intermediate_clip = os.path.join(tempdir.name, event_id+'.mov')
work_doc = os.path.join(tempdir.name, event_id + '.aep')
script_doc = os.path.join(tempdir.name, event_id + '.jsx')
ascript_doc = os.path.join(tempdir.name, event_id + '.scpt')
intermediate_clip = os.path.join(tempdir.name, event_id + '.mov')
if event_id == 'pause' or event_id == 'outro' or event_id == 'bgloop':
copyfile(args.project+event_id+'.aep',work_doc)
copyfile(args.project + event_id + '.aep', work_doc)
if platform.system() == 'Darwin':
run('/Applications/Adobe\ After\ Effects\ CC\ 2018/aerender -project {jobpath} -comp {comp} -output {locationpath}',
run(r'/Applications/Adobe\ After\ Effects\ CC\ 2018/aerender -project {jobpath} -comp {comp} -output {locationpath}',
jobpath=work_doc,
comp=event_id,
locationpath=intermediate_clip)
if platform.system() == 'Windows':
run('C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/aerender.exe -project {jobpath} -comp {comp} -output {locationpath}',
run(r'C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/aerender.exe -project {jobpath} -comp {comp} -output {locationpath}',
jobpath=work_doc,
comp=event_id,
locationpath=intermediate_clip)
else:
with open(args.project+'intro.jsx', 'r') as fp:
with open(args.project + 'intro.jsx', 'r') as fp:
scriptstr = fp.read()
for key, value in event.items():
value = str(value).replace('"', '\\"')
scriptstr = scriptstr.replace("$"+str(key), value)
scriptstr = scriptstr.replace("$" + str(key), value)
with open(script_doc, 'w', encoding='utf-8') as fp:
fp.write(scriptstr)
copyfile(args.project+'intro.aep',work_doc)
copyfile(args.project + 'intro.aep', work_doc)
if platform.system() == 'Darwin':
copyfile(args.project+'intro.scpt',ascript_doc)
copyfile(args.project + 'intro.scpt', ascript_doc)
run('osascript {ascript_path} {jobpath} {scriptpath}',
jobpath=work_doc,
scriptpath=script_doc,
ascript_path=ascript_doc)
run('/Applications/Adobe\ After\ Effects\ CC\ 2018/aerender -project {jobpath} -comp "intro" -output {locationpath}',
run(r'/Applications/Adobe\ After\ Effects\ CC\ 2018/aerender -project {jobpath} -comp "intro" -output {locationpath}',
jobpath=work_doc,
locationpath=intermediate_clip)
if platform.system() == 'Windows':
run_once('C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/AfterFX.exe -noui {jobpath}',
run_once(r'C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/AfterFX.exe -noui {jobpath}',
jobpath=work_doc)
time.sleep(15)
run_once('C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/AfterFX.exe -noui -r {scriptpath}',
run_once(r'C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/AfterFX.exe -noui -r {scriptpath}',
scriptpath=script_doc)
time.sleep(5)
run('C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/aerender.exe -project {jobpath} -comp "intro" -output {locationpath}',
run(r'C:/Program\ Files/Adobe/Adobe\ After\ Effects\ CC\ 2018/Support\ Files/aerender.exe -project {jobpath} -comp "intro" -output {locationpath}',
jobpath=work_doc,
locationpath=intermediate_clip)
return event_id
def finalize_job(job_id, event):
event_id = str(event['id'])
intermediate_clip = os.path.join(tempdir.name, event_id+'.mov')
final_clip = os.path.join(os.path.dirname(args.project), event_id+'.ts')
intermediate_clip = os.path.join(tempdir.name, event_id + '.mov')
final_clip = os.path.join(os.path.dirname(args.project), event_id + '.ts')
run('ffmpeg -y -hide_banner -loglevel error -i {input} -f lavfi -i anullsrc -ar 48000 -ac 2 -map 0:v -c:v mpeg2video -q:v 0 -aspect 16:9 -map 1:a -map 1:a -map 1:a -map 1:a -shortest -f mpegts {output}',
#run('ffmpeg -y -hide_banner -loglevel error -i "{input}" -ar 48000 -ac 1 -map 0:v -c:v mpeg2video -q:v 0 -aspect 16:9 -map 1:0 -c:a copy -map 2:0 -c:a copy -shortest -f mpegts "{output}"',
# run('ffmpeg -y -hide_banner -loglevel error -i "{input}" -ar 48000 -ac 1 -map 0:v -c:v mpeg2video -q:v 0 -aspect 16:9 -map 1:0 -c:a copy -map 2:0 -c:a copy -shortest -f mpegts "{output}"',
input=intermediate_clip,
output=final_clip)
if event_id == 'pause' or event_id == 'outro' or event_id == 'bgloop':
event_print(event, "finalized "+str(event_id)+" to "+final_clip)
event_print(event, "finalized " + str(event_id) + " to " + final_clip)
else:
event_print(event, "finalized intro to "+final_clip)
event_print(event, "finalized intro to " + final_clip)
if args.ids:
@ -250,7 +259,7 @@ for event in events:
print("skipping room %s (%s)" % (event['room'], event['title']))
continue
event_print(event, "enqueued as "+str(event['id']))
event_print(event, "enqueued as " + str(event['id']))
job_id = enqueue_job(event)
if not job_id:
@ -264,13 +273,13 @@ for event in events:
event_id = str(event['id'])
event_print(event, "skipping finalizing job")
if platform.system() == 'Windows':
intermediate_clip = os.path.join(tempdir.name, event_id+'.avi')
final_clip = os.path.join(os.path.dirname(args.project), event_id+'.avi')
intermediate_clip = os.path.join(tempdir.name, event_id + '.avi')
final_clip = os.path.join(os.path.dirname(args.project), event_id + '.avi')
else:
intermediate_clip = os.path.join(tempdir.name, event_id+'.mov')
final_clip = os.path.join(os.path.dirname(args.project), event_id+'.mov')
intermediate_clip = os.path.join(tempdir.name, event_id + '.mov')
final_clip = os.path.join(os.path.dirname(args.project), event_id + '.mov')
copyfile(intermediate_clip, final_clip)
event_print(event, "copied intermediate clip to "+final_clip)
event_print(event, "copied intermediate clip to " + final_clip)
print('all done, cleaning up '+tempdir.name)
print('all done, cleaning up ' + tempdir.name)
tempdir.cleanup()

View file

@ -1,4 +1,5 @@
#!/usr/bin/env python3
# vim: tabstop=4 shiftwidth=4 expandtab
import subprocess
import renderlib
@ -47,17 +48,20 @@ parser.add_argument('--exclude-id', dest='exclude_ids', nargs='+', action="store
args = parser.parse_args()
def headline(str):
print("##################################################")
print(str)
print("##################################################")
print()
def error(str):
headline(str)
parser.print_help()
sys.exit(1)
if not args.motn:
error("The Motion-File is a rquired argument")
@ -78,14 +82,17 @@ if args.debug:
else:
events = list(renderlib.events(args.schedule))
def describe_event(event):
return "#{}: {}".format(event['id'], event['title'])
def event_print(event, message):
print("{} {}".format(describe_event(event), message))
tempdir = tempfile.TemporaryDirectory()
print('working in '+tempdir.name)
print('working in ' + tempdir.name)
def fmt_command(command, **kwargs):
@ -96,10 +103,12 @@ def fmt_command(command, **kwargs):
command = command.format(**args)
return shlex.split(command)
def run(command, **kwargs):
return subprocess.check_call(
fmt_command(command, **kwargs))
def run_output(command, **kwargs):
return subprocess.check_output(
fmt_command(command, **kwargs),
@ -109,14 +118,14 @@ def run_output(command, **kwargs):
def enqueue_job(event):
event_id = str(event['id'])
work_doc = os.path.join(tempdir.name, event_id+'.motn')
intermediate_clip = os.path.join(tempdir.name, event_id+'.mov')
work_doc = os.path.join(tempdir.name, event_id + '.motn')
intermediate_clip = os.path.join(tempdir.name, event_id + '.mov')
with open(args.motn, 'r') as fp:
xmlstr = fp.read()
for key, value in event.items():
xmlstr = xmlstr.replace("$"+str(key), xmlescape(str(value)))
xmlstr = xmlstr.replace("$" + str(key), xmlescape(str(value)))
with open(work_doc, 'w') as fp:
fp.write(xmlstr)
@ -127,16 +136,17 @@ def enqueue_job(event):
jobpath=work_doc,
locationpath=intermediate_clip)
match = re.search("<jobID ([A-Z0-9\-]+) ?\/>", compressor_info)
match = re.search(r"<jobID ([A-Z0-9\-]+) ?\/>", compressor_info)
if not match:
event_print(event, "unexpected output from compressor: \n"+compressor_info)
event_print(event, "unexpected output from compressor: \n" + compressor_info)
return
return match.group(1)
def fetch_job_status():
compressor_status = run_output('/Applications/Compressor.app/Contents/MacOS/Compressor -monitor')
job_status_matches = re.finditer("<jobStatus (.*) \/jobStatus>", compressor_status)
job_status_matches = re.finditer(r"<jobStatus (.*) \/jobStatus>", compressor_status)
status_dict = {}
for match in job_status_matches:
@ -150,8 +160,6 @@ def fetch_job_status():
return status_dict
def filter_finished_jobs(active_jobs):
job_status = fetch_job_status()
@ -169,25 +177,24 @@ def filter_finished_jobs(active_jobs):
elif status == 'Successful':
finished_jobs.append((job_id, event))
else:
event_print(event, "failed with staus="+status+" removing from postprocessing queue")
event_print(event, "failed with staus=" + status + " removing from postprocessing queue")
return new_active_jobs, finished_jobs
def finalize_job(job_id, event):
event_id = str(event['id'])
intermediate_clip = os.path.join(tempdir.name, event_id+'.mov')
final_clip = os.path.join(os.path.dirname(args.motn), event_id+'.ts')
copy_clip = os.path.join(os.path.dirname(args.motn), event_id+'.mov')
intermediate_clip = os.path.join(tempdir.name, event_id + '.mov')
final_clip = os.path.join(os.path.dirname(args.motn), event_id + '.ts')
copy_clip = os.path.join(os.path.dirname(args.motn), event_id + '.mov')
shutil.copy(intermediate_clip, copy_clip)
run('ffmpeg -y -hide_banner -loglevel error -i "{input}" -map 0:v -c:v mpeg2video -q:v 0 -aspect 16:9 -map 0:a -map 0:a -map 0:a -map 0:a -shortest -f mpegts "{output}"',
run('ffmpeg -y -hide_banner -loglevel error -i {input} -f lavfi -i anullsrc -ar 48000 -ac 2 -map 0:v -c:v mpeg2video -q:v 0 -aspect 16:9 -map 1:a -map 1:a -map 1:a -map 1:a -shortest -f mpegts {output}',
input=intermediate_clip,
output=final_clip)
event_print(event, "finalized intro to "+final_clip)
event_print(event, "finalized intro to " + final_clip)
active_jobs = []
@ -204,7 +211,7 @@ for event in filtered_events:
event_print(event, "job was not enqueued successfully, skipping postprocessing")
continue
event_print(event, "enqueued as "+job_id)
event_print(event, "enqueued as " + job_id)
active_jobs.append((job_id, event))
print("waiting for rendering to complete")
@ -219,5 +226,5 @@ while len(active_jobs) > 0:
finalize_job(job_id, event)
print('all done, cleaning up '+tempdir.name)
print('all done, cleaning up ' + tempdir.name)
tempdir.cleanup()

31
make.py
View file

@ -1,10 +1,10 @@
#!/usr/bin/env python3
# vim: tabstop=4 shiftwidth=4 expandtab
import sys
import os
import time
import shutil
from lxml import etree
import tempfile
import threading
import multiprocessing
@ -55,14 +55,14 @@ if len(sys.argv) < 2:
args = parser.parse_args()
if not (args.debug==False or args.id==None):
if not (args.debug is False or args.id is None):
print("##################################################")
print("Error! You must not use --debug and --id together!")
print("##################################################")
parser.print_help()
sys.exit(1)
if not (args.debug==False or args.skip==None):
if not (args.debug is False or args.skip is None):
print("####################################################")
print("Error! You must not use --debug and --skip together!")
print("####################################################")
@ -72,8 +72,8 @@ if not (args.debug==False or args.skip==None):
print(args)
# Set values from argparse
projectname=args.projectpath.strip('/')
projectpath=args.projectpath
projectname = args.projectpath.strip('/')
projectpath = args.projectpath
# Check if project exists
try:
@ -86,12 +86,14 @@ except ImportError:
# just renders one type of video
renderlib.debug = args.debug
renderlib.args = args
#sys.exit(1)
# sys.exit(1)
def render(infile, outfile, sequence, parameters={}, workdir=os.path.join(projectname, 'artwork')):
task = renderlib.Rendertask(infile=infile, outfile=outfile, sequence=sequence, parameters=parameters, workdir=workdir)
return renderlib.rendertask(task)
# debug-mode selected by --debug switch
if renderlib.debug:
print("!!! DEBUG MODE !!!")
@ -105,16 +107,14 @@ if renderlib.debug:
# exit early
sys.exit(0)
# threaded task queue
tasks = Queue()
#initialize args.id and args.skip, if they are not given by the user
if (args.id==None):
# initialize args.id and args.skip, if they are not given by the user
if (args.id is None):
args.id = []
if (args.skip==None):
if (args.skip is None):
args.skip = []
# call into project which generates the tasks
@ -131,12 +131,14 @@ for _ in range(num_worker_threads):
# this lock ensures, that only one thread at a time is writing to stdout
# and avoids output from multiple threads intermixing
printLock = Lock()
def tprint(str):
# aquire lock
printLock.acquire()
# print thread-name and message
print(threading.current_thread().name+': '+str)
print(threading.current_thread().name + ': ' + str)
# release lock
printLock.release()
@ -163,7 +165,7 @@ def worker():
task = renderlib.Rendertask.ensure(tasks.get())
# if it is a stop-sentinal break out of the loop
if task == None:
if task is None:
break
# print that we're about to render a task
@ -192,6 +194,7 @@ def worker():
# mark the sentinal as done
tasks.task_done()
# List of running threads
threads = []
@ -206,7 +209,7 @@ for i in range(num_worker_threads):
# we're doing it the manual way because tasks.join() would wait until all tasks are done,
# even if the worker threads crash due to broken svgs, Ctrl-C termination or whatnot
while True:
if tasks.empty() == True:
if tasks.empty() is True:
break
# sleep while the workers work

View file

@ -1,10 +1,10 @@
#!/usr/bin/python3
# vim: tabstop=4 shiftwidth=4 expandtab
import os
import sys
import re
import glob
import math
import shutil
import errno
from lxml import etree
@ -22,24 +22,27 @@ args = None
cssutils.ser.prefs.lineSeparator = ' '
cssutils.log.setLevel(logging.FATAL)
def loadProject(projectname):
sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), projectname))
return __import__(projectname)
def easeDelay(easer, delay, t, b, c, d, *args):
if t < delay:
return b
if t - delay > d:
return b+c
return b + c
return easer(t - delay, b, c, d, *args)
class Rendertask:
def __init__(self, infile, sequence, parameters={}, outfile=None, workdir='.'):
if isinstance(infile, list):
self.infile = infile[0]
#self.audiofile = infile[1]
# self.audiofile = infile[1]
else:
self.infile = infile
self.audiofile = None
@ -59,6 +62,7 @@ class Rendertask:
else:
return None
# try to create all folders needed and skip, they already exist
def ensurePathExists(path):
try:
@ -67,18 +71,20 @@ def ensurePathExists(path):
if exception.errno != errno.EEXIST:
raise
# remove the files matched by the pattern
def ensureFilesRemoved(pattern):
for f in glob.glob(pattern):
os.unlink(f)
def rendertask(task):
global args
# in debug mode we have no thread-worker which prints its progress
if debug:
print("generating {0} from {1}".format(task.outfile, task.infile))
if not args.skip_frames and not 'only_rerender_frames_after' in task.parameters:
if args.skip_frames and 'only_rerender_frames_after' not in task.parameters:
if os.path.isdir(os.path.join(task.workdir, '.frames')):
shutil.rmtree(os.path.join(task.workdir, '.frames'))
@ -94,7 +100,7 @@ def rendertask(task):
parser = etree.XMLParser(huge_tree=True)
svg = etree.fromstring(svgstr.encode('utf-8'), parser)
#if '$subtitle' in task.parameters and task.parameters['$subtitle'] == '':
# if '$subtitle' in task.parameters and task.parameters['$subtitle'] == '':
# child = svg.findall(".//*[@id='subtitle']")[0]
# child.getparent().remove(child)
@ -137,9 +143,9 @@ def rendertask(task):
for replaceinfo in frame:
(id, type, key, value) = replaceinfo
for el in svg.findall(".//*[@id='"+id.replace("'", "\\'")+"']"):
for el in svg.findall(".//*[@id='" + id.replace("'", "\\'") + "']"):
if type == 'style':
style = cssutils.parseStyle( el.attrib['style'] if 'style' in el.attrib else '' )
style = cssutils.parseStyle(el.attrib['style'] if 'style' in el.attrib else '')
style[key] = str(value)
el.attrib['style'] = style.cssText
@ -153,7 +159,7 @@ def rendertask(task):
# open the output-file (named ".gen.svg" in the workdir)
with open(os.path.join(task.workdir, '.gen.svg'), 'w') as fp:
# write the generated svg-text into the output-file
fp.write( etree.tostring(svg, encoding='unicode') )
fp.write(etree.tostring(svg, encoding='unicode'))
if task.outfile.endswith('.ts') or task.outfile.endswith('.mov'):
width = 1920
@ -166,18 +172,15 @@ def rendertask(task):
cmd = 'cd {0} && inkscape --export-background=white --export-background-opacity=0 --export-width={2} --export-height={3} --export-png=$(pwd)/.frames/{1:04d}.png $(pwd)/.gen.svg 2>&1 >/dev/null'.format(task.workdir, frameNr, width, height)
errorReturn = subprocess.check_output(cmd, shell=True, universal_newlines=True, stderr=subprocess.STDOUT)
if errorReturn != '':
print("inkscape exitted with error\n"+errorReturn)
#sys.exit(42)
print("inkscape exitted with error\n" + errorReturn)
# sys.exit(42)
# increment frame-number
frameNr += 1
if args.only_frame:
task.outfile = '{0}.frame{1:04d}.png'.format(task.outfile, args.only_frame)
# remove the dv/ts we are about to (re-)generate
ensureFilesRemoved(os.path.join(task.workdir, task.outfile))
@ -220,12 +223,12 @@ def rendertask(task):
if not debug:
print("cleanup")
# remove the generated svg
ensureFilesRemoved(os.path.join(task.workdir, '.gen.svg'))
# Download the Events-Schedule and parse all Events out of it. Yield a tupel for each Event
def events(scheduleUrl, titlemap={}):
print("downloading schedule")
@ -249,7 +252,7 @@ def events(scheduleUrl, titlemap={}):
personnames = []
if event.find('persons') is not None:
for person in event.find('persons').iter('person'):
personname = re.sub( '\s+', ' ', person.text ).strip()
personname = re.sub(r'\s+', ' ', person.text).strip()
personnames.append(personname)
id = int(event.get('id'))
@ -257,12 +260,12 @@ def events(scheduleUrl, titlemap={}):
if id in titlemap:
title = titlemap[id]
elif event.find('title') is not None and event.find('title').text is not None:
title = re.sub( '\s+', ' ', event.find('title').text ).strip()
title = re.sub(r'\s+', ' ', event.find('title').text).strip()
else:
title = ''
if event.find('subtitle') is not None and event.find('subtitle').text is not None:
subtitle = re.sub( '\s+', ' ', event.find('subtitle').text ).strip()
subtitle = re.sub(r'\s+', ' ', event.find('subtitle').text).strip()
else:
subtitle = ''
@ -274,9 +277,10 @@ def events(scheduleUrl, titlemap={}):
'persons': personnames,
'personnames': ', '.join(personnames),
'room': room.attrib['name'],
'track' : event.find('track').text
'track': event.find('track').text
}
try:
from termcolor import colored
except ImportError: